Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TrainingTypePlugin.post_dispatch in favor of teardown #10939

Merged
merged 14 commits into from
Dec 6, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 4, 2021

What does this PR do?

Part of #10896 and follow-up to #10885

In #10896 the spawn logic will get redesigned, making the concept of dispatch and post dispatch obsolete. What used to be called post_dispatch does no longer need to be differentiated from teardown. Changes in this PR:

  • Trainer calls accelerator.teardown()
  • Accelerator will call training_type_plugin.teardown()
  • The current TTP will call super().teardown() in it's inherited methods
  • The ParallelPlugin will call teardown also on the cluster environment

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta @tchaton @kaushikb11

@awaelchli awaelchli added this to the 1.6 milestone Dec 4, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli force-pushed the refactor/plugin-teardown branch from d3ec037 to a368657 Compare December 6, 2021 13:20
@awaelchli awaelchli marked this pull request as ready for review December 6, 2021 13:35
@awaelchli awaelchli added the deprecation Includes a deprecation label Dec 6, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 6, 2021
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awaelchli awaelchli enabled auto-merge (squash) December 6, 2021 16:37
@mergify mergify bot added the has conflicts label Dec 6, 2021
@mergify mergify bot removed the has conflicts label Dec 6, 2021
@four4fish
Copy link
Contributor

Awesome! Thank you for address this! How about pre_dispatch, could we deprecate that as well?

@awaelchli
Copy link
Contributor Author

Yes, my idea was to merge it with TTP.setup() method directly after #10896 lands. Given the simplifications that #10896 offers, I think that's the next logical step.

@awaelchli awaelchli merged commit 6bfc0bb into master Dec 6, 2021
@awaelchli awaelchli deleted the refactor/plugin-teardown branch December 6, 2021 22:27
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants