-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TrainingTypePlugin.post_dispatch
in favor of teardown
#10939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
breaking change
Includes a breaking change
refactor
strategy: ddp spawn
labels
Dec 4, 2021
awaelchli
commented
Dec 4, 2021
justusschock
approved these changes
Dec 6, 2021
tchaton
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
force-pushed
the
refactor/plugin-teardown
branch
from
December 6, 2021 13:20
d3ec037
to
a368657
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
awaelchli
requested review from
Borda,
carmocca,
kaushikb11,
rohitgr7,
SeanNaren and
williamFalcon
as code owners
December 6, 2021 13:35
justusschock
reviewed
Dec 6, 2021
kaushikb11
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Justus Schock <[email protected]>
Awesome! Thank you for address this! How about pre_dispatch, could we deprecate that as well? |
awaelchli
added
strategy: ddp
DistributedDataParallel
and removed
strategy: ddp spawn
labels
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
deprecation
Includes a deprecation
ready
PRs ready to be merged
refactor
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #10896 and follow-up to #10885
In #10896 the spawn logic will get redesigned, making the concept of dispatch and post dispatch obsolete. What used to be called
post_dispatch
does no longer need to be differentiated from teardown. Changes in this PR:accelerator.teardown()
training_type_plugin.teardown()
super().teardown()
in it's inherited methodsParallelPlugin
will call teardown also on the cluster environmentBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @justusschock @awaelchli @akihironitta @tchaton @kaushikb11