-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3/n Move Accelerator into strategy - move model_sharded_context() #10886
Conversation
@ananthsub why this will be a breaking change? |
It's a breaking change since we're removing an API from the accelerator interface. If anyone implemented a custom accelerator which overrode |
Yeah make sense! We don't have this override in internal fb or unit test, so didn't think about mark as breaking change. Will mark all move as breaking change then. |
What does this PR do?
Move model_sharded_context() to strategies from Accelerator
Part of #10648
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃