Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3/n Move Accelerator into strategy - move model_sharded_context() #10886

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Dec 1, 2021

What does this PR do?

Move model_sharded_context() to strategies from Accelerator

Part of #10648

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish marked this pull request as draft December 1, 2021 21:14
@four4fish four4fish added this to the 1.6 milestone Dec 1, 2021
@ananthsub ananthsub added the breaking change Includes a breaking change label Dec 1, 2021
@four4fish
Copy link
Contributor Author

@ananthsub why this will be a breaking change?

@ananthsub
Copy link
Contributor

@ananthsub why this will be a breaking change?

It's a breaking change since we're removing an API from the accelerator interface. If anyone implemented a custom accelerator which overrode model_sharded_context this PR would break that usage. I'm using the label more for posterity so its easy to identify all such breaking changes for the 1.6 release

@four4fish
Copy link
Contributor Author

@ananthsub why this will be a breaking change?

It's a breaking change since we're removing an API from the accelerator interface. If anyone implemented a custom accelerator which overrode model_sharded_context this PR would break that usage. I'm using the label more for posterity so its easy to identify all such breaking changes for the 1.6 release

Yeah make sense! We don't have this override in internal fb or unit test, so didn't think about mark as breaking change. Will mark all move as breaking change then.

@four4fish four4fish marked this pull request as ready for review December 1, 2021 22:05
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
@ananthsub ananthsub enabled auto-merge (squash) December 2, 2021 02:55
@ananthsub ananthsub merged commit 45dd806 into Lightning-AI:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator breaking change Includes a breaking change plugin ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants