Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2/n Move Accelerator into strategy - remove dispatch functions from Accelerator #10885

Merged
merged 4 commits into from
Dec 6, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Dec 1, 2021

What does this PR do?

Move dispatch(), pre_dispatch() and post_dispatch() to strategies from Accelerator

Part of #10648

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub
Copy link
Contributor

is #10884 a prerequisite before this? Should we remove the precision plugin pre-dispatch to simplify this PR?

@four4fish
Copy link
Contributor Author

is #10884 a prerequisite before this? Should we remove the precision plugin pre-dispatch to simplify this PR?

@ananthsub do #10844 will simplify this PR, but I was trying to have all function moved today, then start move accelerator to strategy (internal fb code freeze in 2 weeks, so hoping speed up). The #10844 is not blocker and can be done separately. After @awaelchli finishes step 4 in #10059, we can remove pre_dispatch for strategy as well. How about we remove both together then?

@four4fish four4fish reopened this Dec 4, 2021
@four4fish four4fish marked this pull request as ready for review December 4, 2021 00:52
@four4fish four4fish added the breaking change Includes a breaking change label Dec 4, 2021
@four4fish four4fish changed the title 2/n Move Accelerator into strategy - move dispatch functionsto strategy 2/n Move Accelerator into strategy - remove dispatch functions from Accelerator Dec 4, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I made a follow up to this: #10939

@awaelchli awaelchli self-assigned this Dec 5, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 6, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 6, 2021 01:51
@awaelchli awaelchli merged commit 2fc64e9 into Lightning-AI:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator breaking change Includes a breaking change plugin ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants