-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2/n Move Accelerator into strategy - remove dispatch functions from Accelerator #10885
Conversation
is #10884 a prerequisite before this? Should we remove the precision plugin pre-dispatch to simplify this PR? |
@ananthsub do #10844 will simplify this PR, but I was trying to have all function moved today, then start move accelerator to strategy (internal fb code freeze in 2 weeks, so hoping speed up). The #10844 is not blocker and can be done separately. After @awaelchli finishes step 4 in #10059, we can remove pre_dispatch for strategy as well. How about we remove both together then? |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I made a follow up to this: #10939
What does this PR do?
Move dispatch(), pre_dispatch() and post_dispatch() to strategies from Accelerator
Part of #10648
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃