make RichProgressBar more flexible with Rich.Console

[quancs]

The Console inside RichProgressBar is fixed to have its default paramters, which leads to some problems: for example, when force_terminal is True, the progress_bar can be logged in nohup output file. Besides, that is very inflexible for people who want to make some other settings.

What does this PR do?

Add **kwargs to RichProgressBar's init args for initializing its inner Console, so that #10876 can be fixed by passing force_terminal=True

Fixes #10876

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[quancs]

@kaushikb11 Hi, how do you think about this pull request

[kaushikb11]

Hi @quancs, thanks for doing the PR!

I think it would be better to have console_kwargs argument for RichProgressBar.

    def __init__(
        self,
        refresh_rate: int = 1,
        leave: bool = False,
        theme: RichProgressBarTheme = RichProgressBarTheme(),
        console_kwargs: Optional[Dict[str, Any]] = None,
    ) -> None:

[quancs]

console_kwargs: Optional[Dict[str, Any]] = None,

Is this compatible with CLI? @kaushikb11

[SeanNaren]

Thanks for this PR @quancs!

Would've been nicer if we could pass the console as an argument to the rich progress callback, however because of the pickling issue with the Console this would have to be a workaround

[awaelchli]

after #10896 _init_progress should run in the spawned processes already. We can remove this setstate method entirely (in a new PR) if you agree.

[SeanNaren]

:O this would mean we could easily pass in the console object directly through the callback (which would be much nicer imo). @quancs given #10896 has been merged what do you think?

[quancs]

How about this

console_kwargs: Optional[Dict[str, Any], Console] = None,

[SeanNaren]

I'll be up for that, but we could add that in a separate PR if you'd prefer :)

[quancs]

Yeah. So, let's merge this PR?
Or do you have any other thoughts? @awaelchli

[awaelchli]

Yes, are you interested to make a follow up with my proposed change?

[quancs]

Yes, I'd like to. Should I propose a issue first?

[awaelchli]

For my proposal here, no, you can just send a PR: #10875 (comment)

I didn't fully understand what @SeanNaren said but yeah, probably fine to send a PR without issue.

[quancs]

OK