Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove return_result argument from DDPSpawnPlugin.spawn() #10867

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 1, 2021

What does this PR do?

Part of #10034, #10059.

The argument DDPSpawnPlugin.spawn(..., return_result=True|False) was added in #10162 with the request from reviewer(s) that it remains configurable whether to create a mp queue or not. This becomes obsolete with #10034 and can be removed.

Does your PR introduce any breaking changes? If yes, please list them.

Yes, anyone using the spawn() method on the plugin will not be able to pass the argument False anymore.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @tchaton @justusschock @awaelchli @Borda @kaushikb11

@awaelchli awaelchli changed the title remove return_result argument from spawn() Remove return_result argument from DDPSpawnPlugin.spawn() Dec 1, 2021
@awaelchli awaelchli added breaking change Includes a breaking change design Includes a design discussion strategy: ddp spawn labels Dec 1, 2021
@awaelchli awaelchli added this to the 1.6 milestone Dec 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 1, 2021 13:15
@awaelchli awaelchli merged commit 7514adf into master Dec 1, 2021
@awaelchli awaelchli deleted the refactor/spawn/return-result branch December 1, 2021 13:29
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change design Includes a design discussion ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants