Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare version for packages #10762

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Fix compare version for packages #10762

merged 2 commits into from
Nov 26, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 25, 2021

What does this PR do?

Fixes #10702
Closes #10761

It didn't work for

_RICH_AVAILABLE = _module_available("rich") and _compare_version("rich", operator.ge, "10.2.2")

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton

@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task labels Nov 25, 2021
@kaushikb11 kaushikb11 added this to the 1.5.x milestone Nov 25, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) November 25, 2021 16:33
@mergify mergify bot added the ready PRs ready to be merged label Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #10762 (1c4f0a6) into master (b57fecc) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10762   +/-   ##
=======================================
- Coverage      92%      92%   -0%     
=======================================
  Files         177      177           
  Lines       16404    16411    +7     
=======================================
+ Hits        15059    15064    +5     
- Misses       1345     1347    +2     

@kaushikb11 kaushikb11 merged commit e507bc9 into master Nov 26, 2021
@kaushikb11 kaushikb11 deleted the rich/version branch November 26, 2021 09:15
awaelchli pushed a commit that referenced this pull request Nov 27, 2021
lexierule pushed a commit that referenced this pull request Nov 30, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'rich.progress_bar'
6 participants