-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compare version for packages #10762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
Borda,
carmocca,
SeanNaren and
tchaton
as code owners
November 25, 2021 16:20
kaushikb11
requested review from
awaelchli,
justusschock,
rohitgr7 and
williamFalcon
as code owners
November 25, 2021 16:22
awaelchli
approved these changes
Nov 25, 2021
carmocca
approved these changes
Nov 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #10762 +/- ##
=======================================
- Coverage 92% 92% -0%
=======================================
Files 177 177
Lines 16404 16411 +7
=======================================
+ Hits 15059 15064 +5
- Misses 1345 1347 +2 |
rohitgr7
approved these changes
Nov 26, 2021
SkafteNicki
approved these changes
Nov 26, 2021
justusschock
approved these changes
Nov 26, 2021
awaelchli
pushed a commit
that referenced
this pull request
Nov 27, 2021
lexierule
pushed a commit
that referenced
this pull request
Nov 30, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10702
Closes #10761
It didn't work for
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @tchaton