Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fault Tolerant Manual: Add loading to reload the states #10699

Merged
merged 53 commits into from
Nov 23, 2021
Merged

Fault Tolerant Manual: Add loading to reload the states #10699

merged 53 commits into from
Nov 23, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 23, 2021 •
edited
Loading

What does this PR do?

Find the PoC here: #10568

Parts of #10431

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud

awaelchli
awaelchli approved these changes Nov 23, 2021
View reviewed changes
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
@tchaton tchaton mentioned this pull request Nov 23, 2021
Merged
12 tasks
ethanwharris
ethanwharris approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have some minor confusion about the logic

pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Nov 23, 2021
@mergify mergify bot removed the has conflicts label Nov 23, 2021
kaushikb11
kaushikb11 approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaushikb11 kaushikb11 enabled auto-merge (squash) November 23, 2021 14:59
@tchaton tchaton requested a review from carmocca November 23, 2021 15:27
@kaushikb11 kaushikb11 merged commit b28ab34 into master Nov 23, 2021
@kaushikb11 kaushikb11 deleted the add_reloading branch November 23, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
fault tolerance feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@tchaton @awaelchli @ethanwharris @carmocca @justusschock @kaushikb11