Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor slurm_job_id #10622

Merged
merged 10 commits into from
Nov 22, 2021
Merged

refactor slurm_job_id #10622

merged 10 commits into from
Nov 22, 2021

Conversation

AndresAlgaba
Copy link
Contributor

@AndresAlgaba AndresAlgaba commented Nov 18, 2021

What does this PR do?

Fixes #10615

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! thanks for working on it :)

@awaelchli awaelchli self-assigned this Nov 18, 2021
@awaelchli awaelchli added environment: slurm deprecation Includes a deprecation labels Nov 18, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 18, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
Co-authored-by: thomas chaton <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: ananthsub <[email protected]>
@awaelchli awaelchli enabled auto-merge (squash) November 22, 2021 16:50
@awaelchli awaelchli merged commit 6fc7c54 into Lightning-AI:master Nov 22, 2021
@AndresAlgaba AndresAlgaba deleted the refactor/10615_slurm_job_id branch November 22, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation environment: slurm ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate trainer.slurm_job_id
5 participants