-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check torch.distributed availability before sharded tensor state dict hook registration #10621
Merged
carmocca
merged 4 commits into
Lightning-AI:master
from
ananthsub:fix/sharded-tensor-torch-dist-check
Nov 19, 2021
Merged
Check torch.distributed availability before sharded tensor state dict hook registration #10621
carmocca
merged 4 commits into
Lightning-AI:master
from
ananthsub:fix/sharded-tensor-torch-dist-check
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
November 18, 2021 20:37
awaelchli
approved these changes
Nov 18, 2021
carmocca
approved these changes
Nov 18, 2021
akihironitta
approved these changes
Nov 19, 2021
rohitgr7
pushed a commit
that referenced
this pull request
Nov 20, 2021
… hook registration (#10621) Co-authored-by: Carlos Mocholí <[email protected]>
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
… hook registration (Lightning-AI#10621) Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli
pushed a commit
that referenced
this pull request
Nov 24, 2021
… hook registration (#10621) Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Nov 24, 2021
… hook registration (#10621) Co-authored-by: Carlos Mocholí <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10348
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃