Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check torch.distributed availability before sharded tensor state dict hook registration #10621

Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Nov 18, 2021

What does this PR do?

Fixes #10348

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added this to the 1.5.x milestone Nov 18, 2021
@mergify mergify bot removed the has conflicts label Nov 18, 2021
@ananthsub ananthsub added bug Something isn't working lightningmodule pl.LightningModule labels Nov 18, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 18, 2021
@mergify mergify bot removed the has conflicts label Nov 19, 2021
@carmocca carmocca enabled auto-merge (squash) November 19, 2021 17:06
@carmocca carmocca merged commit a18b640 into Lightning-AI:master Nov 19, 2021
@ananthsub ananthsub deleted the fix/sharded-tensor-torch-dist-check branch November 19, 2021 18:27
rohitgr7 pushed a commit that referenced this pull request Nov 20, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningmodule pl.LightningModule ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module 'torch.distributed' has no attribute 'ProcessGroup' when importing PyTorch Lightning
4 participants