Avoid patching common DataHooks to the LightningModule

[rohitgr7]

What does this PR do?

Fixes #10498

If any of these hooks are overridden in both model and datamodule, then we raise a warning and prioritize datamodule.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @ananthsub @ninginthecloud @jjenniferdai @akihironitta

[tchaton]

LGTM !

[ninginthecloud]

Hi, @rohitgr7 I'm ok with this update, thanks a lot for all the change! Would you add the warnings into the codebase as you proposed in the comment? Additionally, we currently have both _DataHookSource and _DataLoaderSource, could we simplify as just one? Afterall, *_dataloader's are also data hooks, the purpose of source is providing a source of truth handling different overridden. Let me know what you think.

[rohitgr7]

Hi, @rohitgr7 I'm ok with this update, thanks a lot for all the change! Would you add the warnings into the codebase as you proposed in the comment? Additionally, we currently have both _DataHookSource and _DataLoaderSource, could we simplify as just one? Afterall, *_dataloader's are also data hooks, the purpose of source is providing a source of truth handling different overridden. Let me know what you think.

yes @ninginthecloud, I was going to propose this in a follow-up issue. Also, we need to ensure to have strict rules there:

1. strictly use LDM for dataloader hooks just like we do now. No warnings in such a case.
2. Strictly follow LDM, if passed, for both common hooks and dataloader hooks. For other hooks, IMO we could start raising the warning for the current behavior i.e if LDM is passed, use hooks for LM if there are not overridden in LDM but overridden in LightningModule. Making LDM as a source of truth always.

else I think it would be really ambiguous to raise a warning for one hook if it's overridden in LM but not in LDM and not raise for another if it's overridden in LDM.

[ninginthecloud]

Thanks for the update!