Avoid deprecated progress_bar_refresh_rate usage

[carmocca]

What does this PR do?

Part of #9939

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• [n/a] Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @awaelchli

[tchaton]

LGTM !

[daniellepintz]

Hmm, are we sure this is the desired behavior here? If a user explicitly overrides the default and sets enable_progress_bar=False it is weird that we still enable a progress bar.

[carmocca]

Hmm, are we sure this is the desired behavior here? If a user explicitly overrides the default and sets enable_progress_bar=False it is weird that we still enable a progress bar.

The user sends a mixed signal, both passing it as a callback and disabling it, we can go for either of them.

[daniellepintz]

I agree with @ananthsub, I think we should just raise a MisConfigException

[codecov]

Codecov Report

Merging #10520 (2c632f3) into master (a8c2725) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 2c632f3 differs from pull request most recent head 7bc1b99. Consider uploading reports for the commit 7bc1b99 to get more accurate results

@@           Coverage Diff           @@
##           master   #10520   +/-   ##
=======================================
  Coverage      92%      93%           
=======================================
  Files         179      178    -1     
  Lines       16270    16190   -80     
=======================================
- Hits        15039    14982   -57     
+ Misses       1231     1208   -23     

[daniellepintz]

Looks good!