Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to_torchscript() causing false positive deprecation warnings #10470

Merged
merged 6 commits into from
Nov 15, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes #10092

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Nov 11, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 11, 2021
@carmocca carmocca self-assigned this Nov 11, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Nov 13, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #10470 (dd16c57) into master (dcafc95) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10470   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         178      178           
  Lines       16240    16244    +4     
=======================================
+ Hits        14901    14905    +4     
  Misses       1339     1339           

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the linked issue open because imo this is just a workaround for an issue in PyTorch.

@mergify mergify bot removed the has conflicts label Nov 15, 2021
@carmocca
Copy link
Contributor Author

We should keep the linked issue open because imo this is just a workaround for an issue in PyTorch.

You still have the issue in the PyTorch repository.

And we will likely remove the deprecation before they fix this.

@carmocca carmocca enabled auto-merge (squash) November 15, 2021 15:43
@mergify mergify bot removed the has conflicts label Nov 15, 2021
@carmocca carmocca merged commit 65ebfed into master Nov 15, 2021
@carmocca carmocca deleted the bugfix/deprecation-torchscript branch November 15, 2021 22:12
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningModule.to_torchscript() causes false positive deprecation warnings
5 participants