-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to_torchscript()
causing false positive deprecation warnings
#10470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10470 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 178 178
Lines 16240 16244 +4
=======================================
+ Hits 14901 14905 +4
Misses 1339 1339 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the linked issue open because imo this is just a workaround for an issue in PyTorch.
You still have the issue in the PyTorch repository. And we will likely remove the deprecation before they fix this. |
What does this PR do?
Fixes #10092
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review