Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated disable_validation property from Trainer #10450

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added the deprecation Includes a deprecation label Nov 10, 2021
@kaushikb11 kaushikb11 added this to the 1.6 milestone Nov 10, 2021
@ananthsub ananthsub added the breaking change Includes a breaking change label Nov 10, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) November 12, 2021 07:04
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! But I think this properly was quite useful though.

@kaushikb11 kaushikb11 force-pushed the remove/disable_validation branch from 81aae0d to f96bff6 Compare November 12, 2021 17:58
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #10450 (f96bff6) into master (8b0cb47) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head f96bff6 differs from pull request most recent head 6f4244f. Consider uploading reports for the commit 6f4244f to get more accurate results

@@           Coverage Diff           @@
##           master   #10450   +/-   ##
=======================================
- Coverage      93%      92%   -0%     
=======================================
  Files         178      179    +1     
  Lines       16196    16284   +88     
=======================================
+ Hits        14988    15056   +68     
- Misses       1208     1228   +20     

@rohitgr7 rohitgr7 merged commit ae71284 into master Nov 15, 2021
@rohitgr7 rohitgr7 deleted the remove/disable_validation branch November 15, 2021 18:42
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants