-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated disable_validation
property from Trainer
#10450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! But I think this properly was quite useful though.
81aae0d
to
f96bff6
Compare
Codecov Report
@@ Coverage Diff @@
## master #10450 +/- ##
=======================================
- Coverage 93% 92% -0%
=======================================
Files 178 179 +1
Lines 16196 16284 +88
=======================================
+ Hits 14988 15056 +68
- Misses 1208 1228 +20 |
What does this PR do?
Part of #10312
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃