Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated DeviceDtypeModuleMixin import #10442

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 9, 2021

What does this PR do?

Part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated code

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor breaking change Includes a breaking change labels Nov 9, 2021
@carmocca carmocca added this to the 1.6 milestone Nov 9, 2021
@carmocca carmocca requested a review from awaelchli as a code owner November 9, 2021 17:43
@carmocca carmocca self-assigned this Nov 9, 2021
@carmocca carmocca enabled auto-merge (squash) November 9, 2021 17:45
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit ebab4be into master Nov 9, 2021
@carmocca carmocca deleted the refactor/remove-depreacted-mixin branch November 9, 2021 18:35
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants