Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated property configure_slurm_dpp from accelerator connector #10370

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Remove deprecated property configure_slurm_dpp from accelerator connector #10370

merged 4 commits into from
Nov 5, 2021

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Nov 5, 2021 •
edited
Loading

What does this PR do?

Fixes a part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yesss !! ☕️

@SauravMaheshkar SauravMaheshkar marked this pull request as ready for review November 5, 2021 09:22
@SauravMaheshkar SauravMaheshkar mentioned this pull request Nov 5, 2021
Merged
12 tasks
@awaelchli awaelchli added breaking change Includes a breaking change deprecation Includes a deprecation labels Nov 5, 2021
@awaelchli awaelchli added this to the v1.6 milestone Nov 5, 2021
@justusschock justusschock enabled auto-merge (squash) November 5, 2021 09:28
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Nov 5, 2021
tchaton
tchaton approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot removed the has conflicts label Nov 5, 2021
@justusschock justusschock merged commit a9bd4fb into Lightning-AI:master Nov 5, 2021
@SauravMaheshkar SauravMaheshkar deleted the remove-configure-slurm branch November 5, 2021 14:12
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@SauravMaheshkar @Raalsky
Remove deprecated property configure_slurm_dpp from accelerator con…
296440f 
…nector (Lightning-AI#10370)

* Remove deprecated configure_slurm_ddp

* Update CHANGELOG

* Remove deprecated tests from test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@akihironitta akihironitta akihironitta approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@SauravMaheshkar @awaelchli @tchaton @justusschock @akihironitta @carmocca