-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated sync_batchnorm and num_nodes attributes in DDP plugins #10357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of Lightning-AI#10312 test_v1_6_0_ddp_num_nodes() test_v1_6_0_ddp_sync_batchnorm()
puhuk
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
November 4, 2021 16:09
Part of Lightning-AI#10312 test_v1_6_0_ddp_num_nodes() test_v1_6_0_ddp_sync_batchnorm()
puhuk
requested review from
Borda,
carmocca,
kaushikb11,
rohitgr7 and
williamFalcon
as code owners
November 4, 2021 16:10
awaelchli
changed the title
Remove deprecated sync_batchnorm and num_nodes attributes in DDPPlugin
Remove deprecated sync_batchnorm and num_nodes attributes in DDP plugins
Nov 5, 2021
awaelchli
approved these changes
Nov 5, 2021
justusschock
approved these changes
Nov 5, 2021
for more information, see https://pre-commit.ci
tchaton
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! !
12 tasks
8 tasks
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
…ins (Lightning-AI#10357) * Remove deprecated sync_batchnorm and num_nodes attributes in DDPPlugin Part of Lightning-AI#10312 test_v1_6_0_ddp_num_nodes() test_v1_6_0_ddp_sync_batchnorm() * Remove deprecated sync_batchnorm and num_nodes attributes in DDPPlugin Part of Lightning-AI#10312 test_v1_6_0_ddp_num_nodes() test_v1_6_0_ddp_sync_batchnorm() * remove deprecation warnings * apply removal to spawn plugin * update changelog * remove num_nodes in deepspeed * remove unused imports * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10312
test_v1_6_0_ddp_num_nodes()
test_v1_6_0_ddp_sync_batchnorm()
What does this PR do?
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃