Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sync_batchnorm and num_nodes attributes in DDP plugins #10357

Merged
merged 10 commits into from
Nov 5, 2021

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Nov 4, 2021

Part of #10312

test_v1_6_0_ddp_num_nodes()
test_v1_6_0_ddp_sync_batchnorm()

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Part of Lightning-AI#10312

test_v1_6_0_ddp_num_nodes()
test_v1_6_0_ddp_sync_batchnorm()
Part of Lightning-AI#10312

test_v1_6_0_ddp_num_nodes()
test_v1_6_0_ddp_sync_batchnorm()
@awaelchli awaelchli changed the title Remove deprecated sync_batchnorm and num_nodes attributes in DDPPlugin Remove deprecated sync_batchnorm and num_nodes attributes in DDP plugins Nov 5, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 5, 2021
@justusschock justusschock enabled auto-merge (squash) November 5, 2021 09:25
@mergify mergify bot added the has conflicts label Nov 5, 2021
@mergify mergify bot removed the has conflicts label Nov 5, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! !

@justusschock justusschock merged commit 9c4112c into Lightning-AI:master Nov 5, 2021
@puhuk puhuk deleted the remove_ddp_sync_num branch November 5, 2021 10:22
@akihironitta akihironitta added this to the v1.6 milestone Nov 5, 2021
@carmocca carmocca mentioned this pull request Nov 8, 2021
8 tasks
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
…ins (Lightning-AI#10357)

* Remove deprecated sync_batchnorm and num_nodes attributes in DDPPlugin

Part of Lightning-AI#10312

test_v1_6_0_ddp_num_nodes()
test_v1_6_0_ddp_sync_batchnorm()

* Remove deprecated sync_batchnorm and num_nodes attributes in DDPPlugin

Part of Lightning-AI#10312

test_v1_6_0_ddp_num_nodes()
test_v1_6_0_ddp_sync_batchnorm()

* remove deprecation warnings

* apply removal to spawn plugin

* update changelog

* remove num_nodes in deepspeed

* remove unused imports

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants