Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated datamodule lifecycle properties #10350

Merged

Conversation

mayeroa
Copy link
Contributor

@mayeroa mayeroa commented Nov 4, 2021

What does this PR do?

Part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

They are deprecated

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@awaelchli awaelchli added breaking change Includes a breaking change deprecation Includes a deprecation labels Nov 4, 2021
@awaelchli awaelchli added this to the v1.6 milestone Nov 4, 2021
@ananthsub ananthsub added the data handling Generic data-related topic label Nov 4, 2021
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/core/test_datamodules.py Outdated Show resolved Hide resolved
tests/core/test_datamodules.py Outdated Show resolved Hide resolved
@mayeroa
Copy link
Contributor Author

mayeroa commented Nov 4, 2021

Should be better now :)

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big one!

@mergify mergify bot added the ready PRs ready to be merged label Nov 5, 2021
@carmocca carmocca enabled auto-merge (squash) November 5, 2021 04:29
@carmocca carmocca merged commit b3c0f12 into Lightning-AI:master Nov 5, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change data handling Generic data-related topic deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants