-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated datamodule lifecycle properties #10350
Merged
carmocca
merged 8 commits into
Lightning-AI:master
from
mayeroa:remove_datamodule_lifecycle_properties
Nov 5, 2021
Merged
Remove deprecated datamodule lifecycle properties #10350
carmocca
merged 8 commits into
Lightning-AI:master
from
mayeroa:remove_datamodule_lifecycle_properties
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeroa
requested review from
ananthsub,
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
November 4, 2021 13:04
awaelchli
approved these changes
Nov 4, 2021
awaelchli
added
breaking change
Includes a breaking change
deprecation
Includes a deprecation
labels
Nov 4, 2021
ananthsub
suggested changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @mayeroa !
With this change, we should also remove the following:
- https://github.com/PyTorchLightning/pytorch-lightning/blob/ce3e63262a7247c1111375b28c90bdd83b42bf3f/pytorch_lightning/core/datamodule.py#L94-L105
- https://github.com/PyTorchLightning/pytorch-lightning/blob/ce3e63262a7247c1111375b28c90bdd83b42bf3f/pytorch_lightning/core/datamodule.py#L409-L483
- Any references to these properties in the trainer, like here: https://github.com/PyTorchLightning/pytorch-lightning/blob/ce3e63262a7247c1111375b28c90bdd83b42bf3f/pytorch_lightning/trainer/connectors/data_connector.py#L143
ananthsub
reviewed
Nov 4, 2021
Should be better now :) |
for more information, see https://pre-commit.ci
ananthsub
reviewed
Nov 4, 2021
carmocca
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big one!
ananthsub
approved these changes
Nov 5, 2021
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
Co-authored-by: Carlos Mocholi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
data handling
Generic data-related topic
deprecation
Includes a deprecation
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #10312
Does your PR introduce any breaking changes? If yes, please list them.
They are deprecated
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list: