Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configure_columns method to RichProgressBar #10288

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 1, 2021

What does this PR do?

Added configure_columns method to RichProgressBar for Users to customize the columns

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this Nov 1, 2021
@kaushikb11 kaushikb11 added callback feature Is an improvement or enhancement labels Nov 1, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Nov 1, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review November 1, 2021 12:52
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #10288 (67a5fd6) into master (45c45dc) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 67a5fd6 differs from pull request most recent head 9ea15b8. Consider uploading reports for the commit 9ea15b8 to get more accurate results

@@           Coverage Diff           @@
##           master   #10288   +/-   ##
=======================================
  Coverage      93%      93%           
=======================================
  Files         182      182           
  Lines       16431    16433    +2     
=======================================
+ Hits        15199    15201    +2     
  Misses       1232     1232           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Rohit Gupta <[email protected]>
@tchaton tchaton enabled auto-merge (squash) November 1, 2021 17:21
@tchaton tchaton merged commit c52d7ba into master Nov 1, 2021
@tchaton tchaton deleted the add/confgure_columns branch November 1, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants