Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable on_load_checkpoint for datamodule for all trainer_fn #10238

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 29, 2021

What does this PR do?

Fixes #10229
In the past, datamodule states were loaded only with .fit while resuming the training using Trainer(resume_from_checkpoint=...). But now since we allow checkpoint for other trainer methods, and datamodule contains all the data-related info, it seems reasonable to load its states as well during .test/predict/validate. The PR changes this behavior.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Sorry, something went wrong.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Oct 29, 2021
@rohitgr7 rohitgr7 added this to the v1.5 milestone Oct 29, 2021
@rohitgr7 rohitgr7 added data handling Generic data-related topic feature Is an improvement or enhancement labels Oct 29, 2021
@rohitgr7 rohitgr7 self-assigned this Oct 29, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SeanNaren SeanNaren merged commit 6609b2e into master Nov 1, 2021
@SeanNaren SeanNaren deleted the enhance/on_load_dm branch November 1, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

call on_load_checkpoint for LightningDataModule
4 participants