Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log(sync_dist=True, on_epoch=True, on_step=True) not reducing on step #10227

Merged
merged 15 commits into from
Oct 29, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 28, 2021

What does this PR do?

Fixes #10122

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Oct 28, 2021
@tchaton tchaton added this to the v1.5 milestone Oct 28, 2021
@tchaton tchaton self-assigned this Oct 28, 2021
@carmocca carmocca added the logging Related to the `LoggerConnector` and `log()` label Oct 28, 2021
@carmocca carmocca changed the title Resolve logging issue sync_dist=True on_epoch=True on_step=True Fix log(sync_dist=True, on_epoch=True, on_step=True) not reducing on step Oct 28, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 28, 2021
@mergify mergify bot removed the has conflicts label Oct 29, 2021
@carmocca carmocca enabled auto-merge (squash) October 29, 2021 02:11
@mergify mergify bot removed the has conflicts label Oct 29, 2021
@carmocca carmocca merged commit 843bf26 into master Oct 29, 2021
@carmocca carmocca deleted the bugfix/10122_metric_reduction_2 branch October 29, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric reduction behaviour of LightningModule.log() across accelerator workers
4 participants