-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let DDPSpawnPlugin.spawn
return a result from rank 0
#10162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Let
Let Oct 27, 2021
DDPSpawn.spawn
return a result from rank 0DDPSpawnPlugin.spawn
return a result from rank 0
awaelchli
added
design
Includes a design discussion
feature
Is an improvement or enhancement
labels
Oct 27, 2021
awaelchli
requested review from
justusschock,
SeanNaren and
tchaton
as code owners
October 27, 2021 07:48
awaelchli
requested review from
Borda,
carmocca,
kaushikb11,
rohitgr7 and
williamFalcon
as code owners
October 27, 2021 08:01
kaushikb11
reviewed
Oct 27, 2021
11 tasks
kaushikb11
approved these changes
Oct 27, 2021
tchaton
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
SeanNaren
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a test for this somewhere?
justusschock
approved these changes
Oct 27, 2021
rohitgr7
approved these changes
Oct 27, 2021
@SeanNaren there there are two tests in Lite #9987 and I just improved one more to check also the rank. |
awaelchli
force-pushed
the
lightning-lite/spawn-return-1
branch
from
October 27, 2021 10:59
5380584
to
f7ab592
Compare
carmocca
reviewed
Oct 27, 2021
four4fish
reviewed
Oct 27, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #9987
Short term motivation: Lite has currently the ability to spawn its run() method by calling the DDPSpawnPlugin.spawn() method. However there is currently no mechanism to transfer a result back to the main process. We solve this problem by allowing the run() function to return a "pickleable" result from rank 0. This gets transferred to the main process through a queue, which gets added in this PR.
Long term motivation: #10059
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)