Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let DDPSpawnPlugin.spawn return a result from rank 0 #10162

Merged
merged 10 commits into from
Oct 28, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 26, 2021

What does this PR do?

Part of #9987

Short term motivation: Lite has currently the ability to spawn its run() method by calling the DDPSpawnPlugin.spawn() method. However there is currently no mechanism to transfer a result back to the main process. We solve this problem by allowing the run() function to return a "pickleable" result from rank 0. This gets transferred to the main process through a queue, which gets added in this PR.

Long term motivation: #10059

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli changed the title Let DDPSpawn.spawn return a result from rank 0 Let DDPSpawnPlugin.spawn return a result from rank 0 Oct 27, 2021
@awaelchli awaelchli added design Includes a design discussion feature Is an improvement or enhancement labels Oct 27, 2021
@awaelchli awaelchli marked this pull request as ready for review October 27, 2021 07:48
@awaelchli awaelchli added this to the v1.5 milestone Oct 27, 2021
@awaelchli awaelchli mentioned this pull request Oct 27, 2021
11 tasks
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Oct 27, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test for this somewhere?

@awaelchli
Copy link
Contributor Author

awaelchli commented Oct 27, 2021

@SeanNaren there there are two tests in Lite #9987 and I just improved one more to check also the rank.

@awaelchli awaelchli force-pushed the lightning-lite/spawn-return-1 branch from 5380584 to f7ab592 Compare October 27, 2021 10:59
@awaelchli awaelchli enabled auto-merge (squash) October 27, 2021 11:23
pytorch_lightning/plugins/training_type/ddp_spawn.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Oct 28, 2021
@awaelchli awaelchli merged commit 63015b5 into master Oct 28, 2021
@awaelchli awaelchli deleted the lightning-lite/spawn-return-1 branch October 28, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants