-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ProgressBar
and rename it to TQDMProgressBar
#10134
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Co-authored-by: ananthsub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are still some references for ProgressBar inside test, docs and codebase.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Yes, I agree. The tests and docs would be updated in a separate PR. |
Why not here? The PR is not long as it is |
Also, it would have lead to obvious merge conflicts in Sean's PR #9647. But I think I would go ahead with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awaelchli @Borda Would need any of your approval for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
Codecov Report
@@ Coverage Diff @@
## master #10134 +/- ##
========================================
+ Coverage 89% 92% +4%
========================================
Files 181 182 +1
Lines 16408 16415 +7
========================================
+ Hits 14543 15182 +639
+ Misses 1865 1233 -632 |
What does this PR do?
Fixes #9302
Deprecate ProgressBar and rename it to TQDMProgressBar.
Follow up PR would be updating the tests and docs.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃