Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ProgressBar and rename it to TQDMProgressBar #10134

Merged
merged 14 commits into from
Nov 1, 2021
Merged

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Oct 25, 2021

What does this PR do?

Fixes #9302

Deprecate ProgressBar and rename it to TQDMProgressBar.

Follow up PR would be updating the tests and docs.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added the deprecation Includes a deprecation label Oct 28, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Oct 28, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review October 28, 2021 17:08
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some references for ProgressBar inside test, docs and codebase.

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@kaushikb11
Copy link
Contributor Author

I think there are still some references for ProgressBar inside test, docs and codebase.

Yes, I agree. The tests and docs would be updated in a separate PR.

@carmocca
Copy link
Contributor

Why not here? The PR is not long as it is

@kaushikb11
Copy link
Contributor Author

Why not here? The PR is not long as it is

Also, it would have lead to obvious merge conflicts in Sean's PR #9647. But I think I would go ahead with it.

@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) October 29, 2021 17:09
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikb11
Copy link
Contributor Author

@awaelchli @Borda Would need any of your approval for this.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #10134 (f02c66e) into master (49dd787) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10134    +/-   ##
========================================
+ Coverage      89%      92%    +4%     
========================================
  Files         181      182     +1     
  Lines       16408    16415     +7     
========================================
+ Hits        14543    15182   +639     
+ Misses       1865     1233   -632     

@kaushikb11 kaushikb11 merged commit 45c45dc into master Nov 1, 2021
@kaushikb11 kaushikb11 deleted the rename/tqdm branch November 1, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ProgressBar callback to TQDMProgressBar
5 participants