Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in reset_seed() that incorrectly converts the PL_SEED_WORKERS environment variable str read to bool #10099

Merged
merged 7 commits into from
Oct 28, 2021

Conversation

low5545
Copy link
Contributor

@low5545 low5545 commented Oct 24, 2021

What does this PR do?

Fixes #10082

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes :)
Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Oct 24, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 24, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2021
@carmocca carmocca enabled auto-merge (squash) October 25, 2021 16:20
@mergify mergify bot removed the has conflicts label Oct 27, 2021
@carmocca carmocca merged commit 83d74bb into Lightning-AI:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reset_seed() sets PL_SEED_WORKERS to 1 even when the environment variable read indicates PL_SEED_WORKERS=0
7 participants