Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify checkpoint load paths [redo #9693] #10061

Merged
merged 45 commits into from
Oct 25, 2021
Merged

Conversation

jjenniferdai
Copy link
Contributor

What does this PR do?

Fixes #9405
rebase/redo #9693

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 self-requested a review October 22, 2021 20:18
jjenniferdai and others added 2 commits October 22, 2021 13:20
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
CHANGELOG.md Show resolved Hide resolved
@rohitgr7 rohitgr7 self-requested a review October 22, 2021 20:37
@mergify mergify bot removed the has conflicts label Oct 22, 2021
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tchaton tchaton enabled auto-merge (squash) October 25, 2021 11:33
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10061 (e8932a1) into master (76081fb) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10061    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         182      182            
  Lines       16157    16140    -17     
========================================
- Hits        14947    14314   -633     
- Misses       1210     1826   +616     

@tchaton tchaton merged commit 6d79184 into Lightning-AI:master Oct 25, 2021
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[checkpoint] Resolve 2 different checkpoint loading paths across fit vs validate/test/predict
6 participants