-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate optimizer step logic to the PrecisionPlugin
#10029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Oct 19, 2021
carmocca
requested review from
awaelchli,
Borda,
edenlightning,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 20, 2021 00:38
Codecov Report
@@ Coverage Diff @@
## master #10029 +/- ##
=======================================
- Coverage 93% 93% -0%
=======================================
Files 180 180
Lines 15892 15909 +17
=======================================
+ Hits 14722 14725 +3
- Misses 1170 1184 +14 |
awaelchli
approved these changes
Oct 20, 2021
justusschock
approved these changes
Oct 20, 2021
SeanNaren
approved these changes
Oct 20, 2021
tchaton
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PrecisionPlugin.pre_optimizer_step
whenever possible. This will make the transition to only allowing the step in thePrecisionPlugin
easier.Part of #9287
Does your PR introduce any breaking changes? If yes, please list them.
None in stable API
Before submitting
PR review