-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run plugin closure before on_before_optimizer_step
[1/2]
#9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
September 3, 2021 01:51
Codecov Report
@@ Coverage Diff @@
## master #9288 +/- ##
======================================
Coverage 92% 92%
======================================
Files 178 178
Lines 14895 14899 +4
======================================
+ Hits 13748 13752 +4
Misses 1147 1147 |
carmocca
force-pushed
the
bugfix/plugin-closure-execution
branch
from
September 6, 2021 13:12
1149a74
to
f078e29
Compare
carmocca
force-pushed
the
bugfix/plugin-closure-execution
branch
from
September 6, 2021 15:32
22fb070
to
33ecf13
Compare
SeanNaren
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @carmocca!
justusschock
approved these changes
Sep 7, 2021
awaelchli
approved these changes
Sep 7, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
12 tasks
justusschock
added a commit
that referenced
this pull request
Sep 7, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes:
on_before_optimizer_step
skipped_backward
value during manual optimization. This is because the closure is not required to return a value in that case.Part 2: #9287
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review