Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWA with a list of learning rates #8747

Merged
merged 5 commits into from
Aug 14, 2021
Merged

Fix SWA with a list of learning rates #8747

merged 5 commits into from
Aug 14, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 5, 2021

What does this PR do?

No issue, found reading the code.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working callback labels Aug 5, 2021
@carmocca carmocca added this to the v1.4.x milestone Aug 5, 2021
@carmocca carmocca self-assigned this Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #8747 (4539d6d) into master (24f0124) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8747   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         169     169           
  Lines       14078   14076    -2     
======================================
- Hits        13052   13051    -1     
+ Misses       1026    1025    -1     

@carmocca carmocca changed the title [WIP] Fix SWA with a list of learning rates Fix SWA with a list of learning rates Aug 11, 2021
@carmocca carmocca marked this pull request as ready for review August 11, 2021 17:20
@mergify mergify bot added the ready PRs ready to be merged label Aug 12, 2021
@Borda Borda merged commit 7d87879 into master Aug 14, 2021
@Borda Borda deleted the bugfix/swa-lr branch August 14, 2021 06:50
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
* Fix swa lrs - needs test

* Add test

* Update CHANGELOG
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Aug 18, 2021
* Fix swa lrs - needs test

* Add test

* Update CHANGELOG
lexierule pushed a commit that referenced this pull request Aug 18, 2021
* Fix swa lrs - needs test

* Add test

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants