Removed duplicated file extension when uploading model checkpoints with NeptuneLogger #11015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When uploading model checkpoints with NeptuneLogger,
ckpt
files are created undersome/namespace/model.ckpt
(for instance) in metadata. When user downloads the file or explores the UI the filename is constructed in a form<last part of namespace>.<file extension>
so in our case it will end up inmodel.ckpt.ckpt
. This PR removes the extension from namespace which would consist of a filenamemodel.ckpt
without dupplicated file extension in filenames.Preview:
Does your PR introduce any breaking changes? If yes, please list them.
Old scripts with Neptune loggers will consist of different metadata structure in Neptune.ai. Filenames after download are now the same as source filenames.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
I'm pretty sure It makes me fun all the time 😉