-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeepSpeed] Do not fail if batch size could not be inferred for logging #10438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
November 9, 2021 15:57
carmocca
reviewed
Nov 9, 2021
carmocca
approved these changes
Nov 9, 2021
awaelchli
approved these changes
Nov 9, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
kaushikb11
approved these changes
Nov 10, 2021
SeanNaren
commented
Nov 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #10438 +/- ##
=========================================
+ Coverage 43% 92% +49%
=========================================
Files 178 178
Lines 16238 16276 +38
=========================================
+ Hits 6937 14937 +8000
+ Misses 9301 1339 -7962 |
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #10437
Adds a try/catch and a check to ensure we only warn if needs be (if logging has been set lower than WARNING).
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃