Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeepSpeed] Do not fail if batch size could not be inferred for logging #10438

Merged
merged 14 commits into from
Nov 16, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Nov 9, 2021

What does this PR do?

Closes #10437

Adds a try/catch and a check to ensure we only warn if needs be (if logging has been set lower than WARNING).

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot added the has conflicts label Nov 9, 2021
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Nov 9, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) November 10, 2021 09:57
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #10438 (7d9dd6f) into master (4117028) will increase coverage by 49%.
The diff coverage is 100%.

❗ Current head 7d9dd6f differs from pull request most recent head 71d65a6. Consider uploading reports for the commit 71d65a6 to get more accurate results

@@            Coverage Diff            @@
##           master   #10438     +/-   ##
=========================================
+ Coverage      43%      92%    +49%     
=========================================
  Files         178      178             
  Lines       16238    16276     +38     
=========================================
+ Hits         6937    14937   +8000     
+ Misses       9301     1339   -7962     

@SeanNaren SeanNaren merged commit e98ace3 into master Nov 16, 2021
@SeanNaren SeanNaren deleted the fix/deepspeed_logging_per_gpu branch November 16, 2021 11:42
@awaelchli awaelchli modified the milestones: 1.6.x, 1.5.x Nov 16, 2021
SeanNaren pushed a commit that referenced this pull request Nov 16, 2021
lexierule pushed a commit that referenced this pull request Nov 16, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged strategy: deepspeed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepSpeed should not fail if batch size cannot be inferred
4 participants