Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure when DataLoader(batch_size=None) is passed #10345

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Fix failure when DataLoader(batch_size=None) is passed #10345

merged 4 commits into from
Nov 4, 2021

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 3, 2021 •
edited by carmocca
Loading

What does this PR do?

Fixes #10344

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes? I ran 'pytest tests/trainer/'
  • Did you list all the breaking changes introduced by this pull request? - None
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@peterdudfield peterdudfield changed the title add test, + add change to data loading batch sample method add change to data loading batch sample method (+test) Nov 3, 2021
@peterdudfield peterdudfield marked this pull request as ready for review November 3, 2021 19:32
@carmocca carmocca added this to the 1.5.x milestone Nov 4, 2021
@carmocca carmocca added bug Something isn't working data handling Generic data-related topic labels Nov 4, 2021
@carmocca carmocca changed the title add change to data loading batch sample method (+test) Fix failure when DataLoader(batch_size=None) is passed Nov 4, 2021
@peterdudfield
Copy link
Contributor Author

peterdudfield commented Nov 4, 2021 •
edited
Loading

@carmocca Thanks for looking at this.
Would you be able to help merge this? There seems to be one 'check' that was cancelled, but I can't re trigger this.

@justusschock
Copy link
Member

@peterdudfield This is not a problem. This was probably due to a timeout. Once we get the approvals we can merge it :)

@justusschock justusschock enabled auto-merge (squash) November 4, 2021 10:26
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2021
@justusschock justusschock merged commit ce3e632 into Lightning-AI:master Nov 4, 2021
carmocca added a commit that referenced this pull request Nov 4, 2021
@peterdudfield @carmocca
Fix failure when DataLoader(batch_size=None) is passed (#10345)
a02e4a1 
Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli pushed a commit that referenced this pull request Nov 9, 2021
@peterdudfield @carmocca @awaelchli
Fix failure when DataLoader(batch_size=None) is passed (#10345)
cd03e94 
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Nov 9, 2021
@peterdudfield @carmocca @lexierule
Fix failure when DataLoader(batch_size=None) is passed (#10345)
2685aa6 
Co-authored-by: Carlos Mocholí <[email protected]>
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@peterdudfield @pre-commit-ci
@carmocca @Raalsky
Fix failure when DataLoader(batch_size=None) is passed (Lightning-A…
c257c7e 
…I#10345)

* add test, + add change to data loading batch sample method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Refactor and CHANGELOG

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

1.5.0 data loader, with batch_size bug
4 participants
@peterdudfield @justusschock @awaelchli @carmocca