Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataLoader inspection and re-instantiation in Lite #10334

Merged
merged 12 commits into from
Nov 5, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 3, 2021

What does this PR do?

Part of #10329

A detailed explanation of why the bug occurs can be found in the linked issue.
A newly added test demonstrates the failure on master.

This fix should be reviewed carefully, at least by @carmocca and @tchaton .

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric labels Nov 3, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 3, 2021
@tchaton
Copy link
Contributor

tchaton commented Nov 4, 2021

@carmocca Do you think we should bring this to Lightning too ?

@mergify mergify bot added ready PRs ready to be merged has conflicts labels Nov 4, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Nov 5, 2021
@carmocca carmocca enabled auto-merge (squash) November 5, 2021 15:11
@awaelchli
Copy link
Contributor Author

Is it the approach of how we handle dataloaders in general or the fix that I added?

@carmocca carmocca disabled auto-merge November 5, 2021 16:55
@carmocca carmocca enabled auto-merge (squash) November 5, 2021 16:55
@carmocca carmocca merged commit 45f6a3b into master Nov 5, 2021
@carmocca carmocca deleted the bugfix/lite-dataloader-wrap branch November 5, 2021 17:31
awaelchli added a commit that referenced this pull request Nov 5, 2021
@carmocca carmocca mentioned this pull request Nov 8, 2021
10 tasks
awaelchli added a commit that referenced this pull request Nov 9, 2021
lexierule pushed a commit that referenced this pull request Nov 9, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants