Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RelativeAverageSpectralError and RootMeanSquaredErrorUsingSlidingWindow #816

Merged
merged 81 commits into from
Feb 28, 2023

Conversation

Piyush-97
Copy link
Contributor

@Piyush-97 Piyush-97 commented Jan 30, 2022

What does this PR do?

This PR adds a new metric Relative Average Spectral Error (RASE), and Root Mean Squared Error using Sliding Window the metric RASE is based upon.

Resolves part of #799

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request New metric labels Jan 30, 2022
@Borda Borda mentioned this pull request Jan 30, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #816 (144fcac) into master (df15e09) will decrease coverage by 49%.
The diff coverage is 95%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #816     +/-   ##
========================================
- Coverage      88%     39%    -49%     
========================================
  Files         219     223      +4     
  Lines       11531   11672    +141     
========================================
- Hits        10189    4597   -5592     
- Misses       1342    7075   +5733     

@SkafteNicki
Copy link
Member

Hi @Piyush-97, thanks for wanting to contribute.
However, I cannot see that you have made any changes. Is that correct?

@Piyush-97
Copy link
Contributor Author

Hi @Piyush-97, thanks for wanting to contribute. However, I cannot see that you have made any changes. Is that correct?

Yes, Sorry about that I was busy with some other work and couldn't give mush time to this.
You can assign this to someone else if this need to be completed fast.
Sorry again.

@stancld stancld changed the title New Metric RASE for images [WIP] Add RelativeAverageSpectralError Mar 5, 2022
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, else LGTM

requirements/test.txt Outdated Show resolved Hide resolved
torchmetrics/functional/image/helper.py Outdated Show resolved Hide resolved
torchmetrics/image/rase.py Outdated Show resolved Hide resolved
torchmetrics/image/rmse_sw.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki marked this pull request as ready for review March 21, 2022 09:02
torchmetrics/image/rmse_sw.py Outdated Show resolved Hide resolved
torchmetrics/image/rmse_sw.py Outdated Show resolved Hide resolved
torchmetrics/image/rase.py Outdated Show resolved Hide resolved
torchmetrics/image/rase.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Mar 21, 2022
@SkafteNicki SkafteNicki added this to the v0.8 milestone Mar 21, 2022
@Borda Borda enabled auto-merge (squash) February 27, 2023 19:11
@mergify mergify bot added the ready label Feb 28, 2023
@Borda Borda merged commit 704ddeb into Lightning-AI:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants