-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RelativeAverageSpectralError
and RootMeanSquaredErrorUsingSlidingWindow
#816
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
========================================
- Coverage 88% 39% -49%
========================================
Files 219 223 +4
Lines 11531 11672 +141
========================================
- Hits 10189 4597 -5592
- Misses 1342 7075 +5733 |
Hi @Piyush-97, thanks for wanting to contribute. |
Yes, Sorry about that I was busy with some other work and couldn't give mush time to this. |
RelativeAverageSpectralError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, else LGTM
What does this PR do?
This PR adds a new metric Relative Average Spectral Error (RASE), and Root Mean Squared Error using Sliding Window the metric RASE is based upon.
Resolves part of #799
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃