Add Tweedie Deviance Score Metric. #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikrangasai
requested review from
ananyahjha93,
Borda,
edenlightning,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 130 132 +2
Lines 4586 4652 +66
=====================================
+ Hits 4373 4425 +52
- Misses 213 227 +14 |
for more information, see https://pre-commit.ci
…/karthikrangasai/metrics into feature/tweedie_deviance_metrics
SkafteNicki
reviewed
Sep 6, 2021
There was a problem hiding this comment.
Hi @karthikrangasai, thanks for the PR
It is looking fairly done, but I think it can be improved (memory wise) by not storing all preds and targets in a buffer but instead some intermediate states. Please see comments, and feel free to reach out to me if it is unclear.
Also remember to add note in changelog :]
SkafteNicki
reviewed
Sep 6, 2021
Borda
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #73 .
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃