Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Support for new icevision version (0.11.0) #989

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #877

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #989 (1d4ae70) into master (a0c97a3) will decrease coverage by 0.03%.
The diff coverage is 76.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   88.48%   88.45%   -0.04%     
==========================================
  Files         250      250              
  Lines       13133    13158      +25     
==========================================
+ Hits        11621    11639      +18     
- Misses       1512     1519       +7     
Flag Coverage Δ
unittests 88.45% <76.31%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 90.27% <75.67%> (-3.89%) ⬇️
flash/core/utilities/imports.py 91.24% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c97a3...1d4ae70. Read the comment docs.

@ethanwharris ethanwharris changed the title [WIP] Support for new icevision version (0.11.0) Support for new icevision version (0.11.0) Nov 22, 2021
@Borda Borda added the enhancement New feature or request label Nov 22, 2021
@ethanwharris ethanwharris merged commit f48fe2f into master Nov 22, 2021
@ethanwharris ethanwharris deleted the bugfix/icevision_11 branch November 22, 2021 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MasksRecordComponent does not exist in icevision
2 participants