-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
- Coverage 84.81% 79.62% -5.19%
==========================================
Files 246 248 +2
Lines 12982 13019 +37
==========================================
- Hits 11011 10367 -644
- Misses 1971 2652 +681
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we should try to deprecate DefaultDataKeys if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! After all conflicts.
c25526b
to
12c4f0f
Compare
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #915
Fixes #921
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃