Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Rename DataSource to Input #929

Merged
merged 30 commits into from
Nov 10, 2021
Merged

Rename DataSource to Input #929

merged 30 commits into from
Nov 10, 2021

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented Nov 4, 2021

What does this PR do?

Fixes #915
Fixes #921

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ananyahjha93 ananyahjha93 changed the title Refactor/data source Rename DataSource to Input Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #929 (9c8b70f) into master (00ef240) will decrease coverage by 5.18%.
The diff coverage is 84.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
- Coverage   84.81%   79.62%   -5.19%     
==========================================
  Files         246      248       +2     
  Lines       12982    13019      +37     
==========================================
- Hits        11011    10367     -644     
- Misses       1971     2652     +681     
Flag Coverage Δ
unittests 79.62% <84.28%> (-5.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/callback.py 100.00% <ø> (ø)
flash/core/data/new_data_module.py 88.09% <ø> (ø)
flash/tabular/__init__.py 100.00% <ø> (ø)
flash/text/seq2seq/core/model.py 45.12% <0.00%> (-21.96%) ⬇️
flash/pointcloud/detection/open3d_ml/app.py 26.59% <16.66%> (ø)
flash/image/face_detection/model.py 39.28% <20.00%> (ø)
flash/tabular/regression/model.py 51.35% <20.00%> (ø)
flash/image/face_detection/data.py 43.66% <23.07%> (ø)
flash/text/question_answering/model.py 26.89% <25.00%> (-1.38%) ⬇️
flash/audio/classification/transforms.py 86.95% <33.33%> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ef240...9c8b70f. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we should try to deprecate DefaultDataKeys if possible

docs/source/template/data.rst Outdated Show resolved Hide resolved
docs/source/template/data.rst Outdated Show resolved Hide resolved
flash/core/data/io/input.py Outdated Show resolved Hide resolved
flash/core/data/io/input.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! After all conflicts.

docs/source/general/data.rst Outdated Show resolved Hide resolved
flash/__init__.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Nov 9, 2021
@ethanwharris ethanwharris merged commit e983c1e into master Nov 10, 2021
@ethanwharris ethanwharris deleted the refactor/data_source branch November 10, 2021 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change data_source argument in Task.predict to input Rename DataSource to Input
3 participants