Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix testing loop in Active Learning #879

Merged
merged 11 commits into from
Oct 29, 2021

Conversation

Dref360
Copy link
Contributor

@Dref360 Dref360 commented Oct 19, 2021

What does this PR do?

Test metrics were not logged correctly.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #879 (685bfaf) into master (e63a9a1) will decrease coverage by 0.06%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   89.08%   89.01%   -0.07%     
==========================================
  Files         230      230              
  Lines       12708    12719      +11     
==========================================
+ Hits        11321    11322       +1     
- Misses       1387     1397      +10     
Flag Coverage Δ
unittests 89.01% <10.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ash/image/classification/integrations/baal/data.py 41.48% <0.00%> (+1.28%) ⬆️
...ash/image/classification/integrations/baal/loop.py 31.73% <10.52%> (-3.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63a9a1...685bfaf. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

flash/image/classification/integrations/baal/loop.py Outdated Show resolved Hide resolved
@Dref360
Copy link
Contributor Author

Dref360 commented Oct 29, 2021

Hello, anything missing on this? Once this is merged, I'll update our example on BaaL and finalize the blog post.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@ethanwharris ethanwharris enabled auto-merge (squash) October 29, 2021 13:25
@ethanwharris ethanwharris merged commit 194c8d9 into Lightning-Universe:master Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants