Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

move classification integration from vision root to folder #86

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Move classification integration test from vision root to folder

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #86 (a1fe689) into master (b629006) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files          45       45           
  Lines        1370     1370           
=======================================
  Hits         1187     1187           
  Misses        183      183           
Flag Coverage Δ
unittests 86.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b629006...51d6586. Read the comment docs.

@kaushikb11 kaushikb11 enabled auto-merge (squash) February 8, 2021 14:31
@Borda Borda added the enhancement New feature or request label Feb 8, 2021
@kaushikb11 kaushikb11 disabled auto-merge February 8, 2021 17:11
@kaushikb11 kaushikb11 changed the title Move classification integration test from vision root to folder move classification integration from vision root to folder Feb 8, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) February 8, 2021 17:38
@kaushikb11 kaushikb11 disabled auto-merge February 9, 2021 04:47
@kaushikb11 kaushikb11 merged commit 6c047f0 into Lightning-Universe:master Feb 10, 2021
@kaushikb11 kaushikb11 deleted the move/test_model_data branch February 10, 2021 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants