Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

AudioClassificationData from_numpy and from_tensors #745

Merged
merged 5 commits into from
Sep 7, 2021

Conversation

ethanwharris
Copy link
Collaborator

…ile types

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #745 (f3e8aab) into master (75afa79) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   89.65%   89.65%   -0.01%     
==========================================
  Files         198      198              
  Lines       10667    10681      +14     
==========================================
+ Hits         9564     9576      +12     
- Misses       1103     1105       +2     
Flag Coverage Δ
unittests 89.65% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/transforms.py 86.95% <66.66%> (-13.05%) ⬇️
flash/audio/classification/data.py 95.74% <100.00%> (+3.43%) ⬆️
flash/image/data.py 95.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75afa79...f3e8aab. Read the comment docs.

@ethanwharris ethanwharris changed the title Turn off spectrogram augmentation by default, drop npz from allowed f… AudioClassificationData from_numpy and from_tensors Sep 7, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris merged commit 282d43d into master Sep 7, 2021
@ethanwharris ethanwharris deleted the bugfix/audio_numpy_loading branch September 7, 2021 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants