Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pytorch Geometric integration #73

Merged
merged 69 commits into from
Jul 14, 2021

Conversation

PabloAMC
Copy link
Contributor

@PabloAMC PabloAMC commented Feb 5, 2021

What does this PR do?

PyTorch geometric integration, initially with graph classification support

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Feb 5, 2021

Hello @PabloAMC! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-14 16:29:31 UTC

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #73 (7b2734f) into master (7237a9f) will increase coverage by 0.03%.
The diff coverage is 94.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   91.67%   91.71%   +0.03%     
==========================================
  Files         117      122       +5     
  Lines        7210     7327     +117     
==========================================
+ Hits         6610     6720     +110     
- Misses        600      607       +7     
Flag Coverage Δ
unittests 91.71% <94.01%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/graph/classification/data.py 79.31% <79.31%> (ø)
flash/graph/data.py 95.00% <95.00%> (ø)
flash/core/utilities/imports.py 90.62% <100.00%> (+0.40%) ⬆️
flash/graph/__init__.py 100.00% <100.00%> (ø)
flash/graph/classification/__init__.py 100.00% <100.00%> (ø)
flash/graph/classification/model.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7237a9f...7b2734f. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work ! Almost there !

flash/graph/GraphClassification/data.py Outdated Show resolved Hide resolved
flash/graph/GraphClassification/data.py Outdated Show resolved Hide resolved
flash/graph/GraphClassification/data.py Outdated Show resolved Hide resolved
flash/graph/GraphClassification/model.py Outdated Show resolved Hide resolved
flash/graph/GraphClassification/model.py Outdated Show resolved Hide resolved
@Borda Borda added enhancement New feature or request task flash Task labels Feb 8, 2021
@aribornstein
Copy link
Contributor

aribornstein commented Feb 10, 2021

Whats the status on this, it looks extremely cool.

@Borda
Copy link
Member

Borda commented Mar 3, 2021

@PabloAMC @tchaton how is it going here?

Copy link

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, thanks a lot for this effort :) I only have minor requests.

Edit: Wondering whether it's really necessary to push the dataset to the repository, as the data will be automatically downloaded.

flash_examples/finetuning/graph_classification.py Outdated Show resolved Hide resolved
requirements/datatype_graph.txt Outdated Show resolved Hide resolved
@PabloAMC
Copy link
Contributor Author

PabloAMC commented Jun 8, 2021

@ethanwharris I think this branch is ready for review. The only thing I am not fully sure about is the GraphSequenceDataSource() and class method from_pygdatasequence in DataModule; and the corresponding tests. The rest was mostly done by @tchaton :)

@mergify mergify bot removed the has conflicts label Jul 14, 2021
@mergify mergify bot removed the has conflicts label Jul 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Awesome work.

flash/graph/classification/data.py Show resolved Hide resolved
# 1. Create the DataModule
dataset = TUDataset(root="data", name="KKI")

datamodule = GraphClassificationData.from_datasets(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add from_folders support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a branch on my repository for the from_sequence support, so perhaps I can add it there and create a PR :-)

@ethanwharris ethanwharris enabled auto-merge (squash) July 14, 2021 16:29
@ethanwharris ethanwharris disabled auto-merge July 14, 2021 16:32
@ethanwharris ethanwharris merged commit a340464 into Lightning-Universe:master Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request task flash Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants