-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
Hello @PabloAMC! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-14 16:29:31 UTC |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 91.67% 91.71% +0.03%
==========================================
Files 117 122 +5
Lines 7210 7327 +117
==========================================
+ Hits 6610 6720 +110
- Misses 600 607 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work ! Almost there !
Whats the status on this, it looks extremely cool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool, thanks a lot for this effort :) I only have minor requests.
Edit: Wondering whether it's really necessary to push the dataset to the repository, as the data will be automatically downloaded.
@ethanwharris I think this branch is ready for review. The only thing I am not fully sure about is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! Awesome work.
# 1. Create the DataModule | ||
dataset = TUDataset(root="data", name="KKI") | ||
|
||
datamodule = GraphClassificationData.from_datasets( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add from_folders
support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a branch on my repository for the from_sequence
support, so perhaps I can add it there and create a PR :-)
What does this PR do?
PyTorch geometric integration, initially with graph classification support
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃