Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix bug when passing metrics as empty list #660

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Aug 16, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #660 (559a5e4) into master (9061d4b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         173      173           
  Lines        9232     9232           
=======================================
  Hits         8363     8363           
  Misses        869      869           
Flag Coverage Δ
gpu ?
pytest ?
unittests 90.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/classification.py 96.52% <100.00%> (ø)
flash/image/classification/model.py 76.92% <100.00%> (ø)
flash/text/classification/model.py 93.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9061d4b...559a5e4. Read the comment docs.

@Borda Borda added the bug / fix Something isn't working label Aug 16, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I see the fix? mind highlight it...

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@tchaton tchaton merged commit b766cc3 into master Aug 16, 2021
@tchaton tchaton deleted the bugfix/no_metrics branch August 16, 2021 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants