Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Catch ValueError in module available #615

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jul 27, 2021

What does this PR do?

Fixes #614

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #615 (d6ce1fb) into master (0890270) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   89.98%   89.96%   -0.03%     
==========================================
  Files         149      149              
  Lines        8456     8458       +2     
==========================================
  Hits         7609     7609              
- Misses        847      849       +2     
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.96% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/imports.py 89.81% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0890270...d6ce1fb. Read the comment docs.

@ethanwharris ethanwharris merged commit 2033c9e into master Jul 27, 2021
@ethanwharris ethanwharris deleted the bugfix/valueerror_spec branch July 27, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to import flash as transformer.__spec__ is returning None
1 participant