Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

Kinyugo
Copy link
Contributor

@Kinyugo Kinyugo commented Jul 15, 2021

What does this PR do?

Fixes #520
Fixes #521
Fixes #522
Fixes #523
Fixes #524
Fixes #525

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2021

Hello @Kinyugo! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-16 20:05:15 UTC

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #594 (a3297c9) into master (5b853c2) will decrease coverage by 0.49%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   89.91%   89.42%   -0.50%     
==========================================
  Files         140      144       +4     
  Lines        8199     8253      +54     
==========================================
+ Hits         7372     7380       +8     
- Misses        827      873      +46     
Flag Coverage Δ
unittests 89.42% <96.66%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/data.py 93.75% <93.75%> (ø)
flash/audio/__init__.py 100.00% <100.00%> (ø)
flash/audio/classification/__init__.py 100.00% <100.00%> (ø)
flash/audio/classification/transforms.py 100.00% <100.00%> (ø)
flash/core/utilities/imports.py 91.17% <100.00%> (+0.36%) ⬆️
flash/graph/classification/model.py 37.70% <0.00%> (-62.30%) ⬇️
flash/graph/data.py 45.00% <0.00%> (-50.00%) ⬇️
flash/graph/classification/data.py 65.51% <0.00%> (-13.80%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b853c2...a3297c9. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @Kinyugo really cool! 😃

@ethanwharris ethanwharris enabled auto-merge (squash) July 16, 2021 20:09
@ethanwharris ethanwharris merged commit 6214983 into Lightning-Universe:master Jul 16, 2021
@Kinyugo Kinyugo deleted the feature/task-a-thon-audio-classification-spectrograms branch July 18, 2021 08:48
@Kinyugo Kinyugo restored the feature/task-a-thon-audio-classification-spectrograms branch July 18, 2021 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants