This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Graph embedding and graph backbones #592
Merged
ethanwharris
merged 205 commits into
Lightning-Universe:master
from
PabloAMC:task_a_thon
Nov 9, 2021
Merged
Graph embedding and graph backbones #592
ethanwharris
merged 205 commits into
Lightning-Universe:master
from
PabloAMC:task_a_thon
Nov 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lacking Pipeline and it is possible that division in raw and processed folders might be needed.
I'm unsure how to adapt
Lacking Pipeline and it is possible that division in raw and processed folders might be needed.
I'm unsure how to adapt
The class BasicGraphDataset in graphClassification/data.py is probably unneded
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…raphDatasetSource()
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ethanwharris
changed the title
Graph embedding and graph backbones (task-a-thon)
Graph embedding and graph backbones
Nov 9, 2021
tchaton
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
from flash.core.utilities.providers import _PYTORCH_GEOMETRIC | ||
|
||
if _GRAPH_AVAILABLE: | ||
from torch_geometric.nn.models import GAT, GCN, GIN, GraphSAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we automate this and get all their models ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not possible to do cleanly at the moment as the models package also contains many other things that wouldn't work in the GraphClassifier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #510
Fixes #511
Fixes #512
Fixes #513
Fixes #514
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃