Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

add available weights to SMP #587

Merged
merged 14 commits into from
Jul 14, 2021
Merged

add available weights to SMP #587

merged 14 commits into from
Jul 14, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Jul 14, 2021

What does this PR do?

Fixes #517 #518 #519

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #587 (5492d31) into master (9c42528) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   90.63%   90.65%   +0.01%     
==========================================
  Files         132      132              
  Lines        7766     7777      +11     
==========================================
+ Hits         7039     7050      +11     
  Misses        727      727              
Flag Coverage Δ
unittests 90.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/backbones.py 100.00% <100.00%> (ø)
flash/image/segmentation/heads.py 95.45% <100.00%> (+0.71%) ⬆️
flash/image/segmentation/model.py 90.66% <100.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c42528...5492d31. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looking really neat 😃 I think the only thing that's missing is checking if pretrained is a string when loading the head and using that for the weights path

@aniketmaurya
Copy link
Contributor Author

aniketmaurya commented Jul 14, 2021

Awesome, looking really neat 😃 I think the only thing that's missing is checking if pretrained is a string when loading the head and using that for the weights path

updated @ethanwharris

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

flash/image/segmentation/heads.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for weights paths to the SEMANTIC_SEGMENTATION_BACKBONES registry
2 participants