Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

segmentation_models.pytorch integration #562

Merged
merged 19 commits into from
Jul 13, 2021
Merged

segmentation_models.pytorch integration #562

merged 19 commits into from
Jul 13, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Jul 11, 2021

What does this PR do?

Fixes #515 #516

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #562 (7121dfb) into master (c318e4a) will decrease coverage by 1.41%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   91.27%   89.86%   -1.42%     
==========================================
  Files         117      117              
  Lines        7234     7191      -43     
==========================================
- Hits         6603     6462     -141     
- Misses        631      729      +98     
Flag Coverage Δ
unittests 89.86% <96.55%> (-1.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/data.py 81.33% <ø> (ø)
flash/image/segmentation/heads.py 94.73% <93.33%> (+16.77%) ⬆️
flash/core/utilities/imports.py 89.65% <100.00%> (+0.12%) ⬆️
flash/image/segmentation/backbones.py 100.00% <100.00%> (ø)
flash/image/segmentation/model.py 89.70% <100.00%> (+1.64%) ⬆️
flash/text/seq2seq/core/metrics.py 74.07% <0.00%> (-23.15%) ⬇️
flash/text/classification/model.py 70.45% <0.00%> (-22.73%) ⬇️
flash/text/classification/data.py 66.66% <0.00%> (-22.43%) ⬇️
flash/text/seq2seq/core/data.py 72.00% <0.00%> (-20.00%) ⬇️
flash/text/seq2seq/core/model.py 66.66% <0.00%> (-8.70%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c318e4a...7121dfb. Read the comment docs.

@aniketmaurya aniketmaurya marked this pull request as ready for review July 12, 2021 17:43
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

flash/image/segmentation/backbones.py Show resolved Hide resolved
flash/image/segmentation/heads.py Show resolved Hide resolved
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 😃

@ethanwharris ethanwharris enabled auto-merge (squash) July 13, 2021 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants