Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Enable semantic segmentation backbone and head #412

Merged
merged 11 commits into from
Jun 16, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 15, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #412 (e256ef1) into master (25d6633) will decrease coverage by 0.18%.
The diff coverage is 74.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   90.26%   90.08%   -0.19%     
==========================================
  Files         111      112       +1     
  Lines        6957     6999      +42     
==========================================
+ Hits         6280     6305      +25     
- Misses        677      694      +17     
Flag Coverage Δ
gpu ?
pytest ?
unittests 90.08% <74.11%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 78.30% <50.00%> (ø)
flash/image/segmentation/heads.py 68.85% <68.85%> (ø)
flash/image/segmentation/model.py 86.56% <80.00%> (-0.10%) ⬇️
flash/image/segmentation/backbones.py 100.00% <100.00%> (+10.86%) ⬆️
flash/image/backbones.py 78.64% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d6633...e256ef1. Read the comment docs.

@mergify mergify bot removed the has conflicts label Jun 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

flash/image/segmentation/heads.py Outdated Show resolved Hide resolved
@Lightning-Universe Lightning-Universe deleted a comment from pep8speaks Jun 16, 2021
@ethanwharris ethanwharris merged commit 6ea2a3c into master Jun 16, 2021
@ethanwharris ethanwharris deleted the bugfix/segmentation_backbones branch June 16, 2021 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants