Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Multi-label text classification #401

Merged
merged 11 commits into from
Jun 11, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 11, 2021

What does this PR do?

Fixes #397 Fixes #396

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #401 (1101871) into master (bec7142) will increase coverage by 4.14%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   80.56%   84.71%   +4.14%     
==========================================
  Files         109      109              
  Lines        6591     6607      +16     
==========================================
+ Hits         5310     5597     +287     
+ Misses       1281     1010     -271     
Flag Coverage Δ
unittests 84.71% <80.00%> (+4.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/data.py 84.21% <72.72%> (+47.14%) ⬆️
flash/text/classification/model.py 88.63% <77.77%> (+49.61%) ⬆️
flash/core/data/data_module.py 93.54% <100.00%> (+0.49%) ⬆️
flash/core/model.py 80.84% <100.00%> (+6.12%) ⬆️
flash/core/data/properties.py 100.00% <0.00%> (+1.33%) ⬆️
flash/text/seq2seq/translation/data.py 100.00% <0.00%> (+12.50%) ⬆️
flash/text/seq2seq/summarization/data.py 100.00% <0.00%> (+12.50%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec7142...1101871. Read the comment docs.

@ethanwharris ethanwharris marked this pull request as ready for review June 11, 2021 19:13
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris merged commit d23319d into master Jun 11, 2021
@ethanwharris ethanwharris deleted the feature/multilabel_text branch June 11, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multilabel text classification not working Multilabel text classification example
3 participants