Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Jit support #389

Merged
merged 13 commits into from
Jun 10, 2021
Merged

Jit support #389

merged 13 commits into from
Jun 10, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 9, 2021

What does this PR do?

Makes flash tasks jittable where possible:
Todo:

  • Image classification
  • object detection
  • style transfer
  • embedding
  • tabular
  • template task
  • text classification
  • translation
  • summarisation
  • video
  • docs

Fixes #386

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #389 (9540acc) into master (a047330) will increase coverage by 0.33%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   89.45%   89.79%   +0.33%     
==========================================
  Files          80       80              
  Lines        4192     4203      +11     
==========================================
+ Hits         3750     3774      +24     
+ Misses        442      429      -13     
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.79% <90.62%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/model.py 86.36% <ø> (-0.88%) ⬇️
flash/image/detection/model.py 80.51% <60.00%> (+0.51%) ⬆️
flash/text/classification/model.py 90.00% <80.00%> (+0.52%) ⬆️
flash/core/data/process.py 88.83% <100.00%> (-6.10%) ⬇️
flash/core/model.py 87.54% <100.00%> (+0.20%) ⬆️
flash/image/embedding/model.py 81.03% <100.00%> (+40.68%) ⬆️
flash/image/segmentation/model.py 86.88% <100.00%> (ø)
flash/tabular/classification/model.py 83.72% <100.00%> (+1.66%) ⬆️
flash/image/detection/data.py 95.16% <0.00%> (-1.62%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a047330...9540acc. Read the comment docs.

@Borda Borda added the enhancement New feature or request label Jun 10, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@ethanwharris ethanwharris merged commit b49bf04 into master Jun 10, 2021
@ethanwharris ethanwharris deleted the feature/jit_script branch June 10, 2021 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support torch.jit.script for tasks
4 participants