Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix from_argparse_args #380

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fix from_argparse_args #380

merged 3 commits into from
Jun 8, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 8, 2021

What does this PR do?

Fixes #379

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [-] Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #380 (3002ba3) into master (28b5a1e) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files          80       80           
  Lines        4180     4192   +12     
=======================================
+ Hits         3739     3750   +11     
- Misses        441      442    +1     
Flag Coverage Δ
unittests 89.45% <92.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/trainer.py 87.50% <92.30%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b5a1e...3002ba3. Read the comment docs.

@ethanwharris ethanwharris merged commit bd365e6 into master Jun 8, 2021
@ethanwharris ethanwharris deleted the bugfix/from_argparse_args branch June 8, 2021 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash Trainer.from_argparse_args not working
2 participants