-
Notifications
You must be signed in to change notification settings - Fork 211
enforce random sampling at first call in kornia parallell transforms #351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 80 80
Lines 4143 4144 +1
=======================================
+ Hits 3680 3681 +1
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some failing tests. Is there any reason anyonme would want to do this though? It looks like reuse_params=True
will make it apply the same transform every time, so you're not really getting an augmentation just a constant transform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
Hello @edgarriba! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-01 14:06:51 UTC |
What does this PR do?
enables to reuse the transforms parameters for kornia transforms in different calls
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃